Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with numpy 2.0 #1094

Merged
merged 16 commits into from
Jun 28, 2024
Merged

Add compatibility with numpy 2.0 #1094

merged 16 commits into from
Jun 28, 2024

Conversation

RedTachyon
Copy link
Member

@RedTachyon RedTachyon commented Jun 27, 2024

Numpy broke some things with the 2.0 release: https://numpy.org/doc/stable/release/2.0.0-notes.html

The tentative policy is that Gymnasium will support both numpy 1.x and 2.x, at least for the foreseeable future. Of course there will be complications everywhere in downstream projects that have other dependencies, but the changes are minor enough that we should be able to handle it here. There will also be minor incompatibilities here, like conflicts with pytorch, and the fact that numpy 2.0 doesn't support python 3.8. Nothing we can do about that.

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@RedTachyon RedTachyon marked this pull request as ready for review June 28, 2024 16:47
@RedTachyon RedTachyon changed the title [WIP] Add compatibility with numpy 2.0 Add compatibility with numpy 2.0 Jun 28, 2024
@RedTachyon RedTachyon merged commit 8161d7d into main Jun 28, 2024
23 checks passed
@pseudo-rnd-thoughts pseudo-rnd-thoughts deleted the np2.0 branch June 29, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants